From: Jason Dillaman <dillaman@redhat.com>
Date: Tue, 22 Dec 2020 18:56:59 +0000 (-0500)
Subject: librbd/migration: fixed missing return statements on stream error path
X-Git-Tag: v16.1.0~149^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7044a9d6ffc6485ec7fffc4f947b0683f1f0ffc9;p=ceph.git

librbd/migration: fixed missing return statements on stream error path

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
---

diff --git a/src/librbd/migration/HttpStream.cc b/src/librbd/migration/HttpStream.cc
index 7b8f91a325cb..fa3cc00320e4 100644
--- a/src/librbd/migration/HttpStream.cc
+++ b/src/librbd/migration/HttpStream.cc
@@ -56,6 +56,7 @@ void HttpStream<I>::close(Context* on_finish) {
 
   if (!m_http_client) {
     on_finish->complete(0);
+    return;
   }
 
   m_http_client->close(on_finish);
diff --git a/src/librbd/migration/S3Stream.cc b/src/librbd/migration/S3Stream.cc
index 222a08ee3fe9..46165f208f9d 100644
--- a/src/librbd/migration/S3Stream.cc
+++ b/src/librbd/migration/S3Stream.cc
@@ -128,6 +128,7 @@ void S3Stream<I>::close(Context* on_finish) {
 
   if (!m_http_client) {
     on_finish->complete(0);
+    return;
   }
 
   m_http_client->close(on_finish);