From: Patrick Donnelly <pdonnell@redhat.com>
Date: Fri, 27 Sep 2024 17:42:48 +0000 (-0400)
Subject: mds: do not dump empty bufptr
X-Git-Tag: v20.0.0~884^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=706eb26f560bfdd7c34c62445d27c9ebf7f7ad26;p=ceph.git

mds: do not dump empty bufptr

Fixes: https://tracker.ceph.com/issues/68243
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
---

diff --git a/src/mds/CInode.cc b/src/mds/CInode.cc
index 0e9b6996ad2c..dfad411d323d 100644
--- a/src/mds/CInode.cc
+++ b/src/mds/CInode.cc
@@ -4589,8 +4589,11 @@ void InodeStoreBase::dump(Formatter *f) const
     for (const auto& [key, val] : *xattrs) {
       f->open_object_section("xattr");
       f->dump_string("key", key);
-      std::string v(val.c_str(), val.length());
-      f->dump_string("val", v);
+      if (val.length()) {
+        f->dump_string("val", std::string(val.c_str(), val.length()));
+      } else {
+        f->dump_string("val", "");
+      }
       f->close_section();
     }
   }