From: Matan Breizman <mbreizma@redhat.com>
Date: Mon, 29 Aug 2022 11:48:41 +0000 (+0300)
Subject: test/osd/RadosModel: WriteOp check retval and is_complete
X-Git-Tag: v18.0.0~9^2~3
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=709f8a9f2851a68f7cc5401a7c0b20b8cd942e32;p=ceph-ci.git

test/osd/RadosModel: WriteOp check retval and is_complete

This change could allow us to have a better understanding on why read got a wrong version.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---

diff --git a/src/test/osd/RadosModel.h b/src/test/osd/RadosModel.h
index 15b7ea8b53d..31c4bf20b7e 100644
--- a/src/test/osd/RadosModel.h
+++ b/src/test/osd/RadosModel.h
@@ -1059,12 +1059,16 @@ public:
       }
 
       context->update_object_version(oid, version);
+      ceph_assert(rcompletion->is_complete());
+      int r = rcompletion->get_return_value();
+      assertf(r >= 0, "r = %d", r);
       if (rcompletion->get_version64() != version) {
 	std::cerr << "Error: racing read on " << oid << " returned version "
 		  << rcompletion->get_version64() << " rather than version "
 		  << version << std::endl;
 	ceph_abort_msg("racing read got wrong version");
       }
+      rcompletion->release();
 
       {
 	ObjectDesc old_value;
@@ -1076,7 +1080,6 @@ public:
 		    << old_value.most_recent() << std::endl;
       }
 
-      rcompletion->release();
       context->oid_in_use.erase(oid);
       context->oid_not_in_use.insert(oid);
       context->kick();