From: Sage Weil <sage@redhat.com>
Date: Tue, 14 Apr 2015 16:35:04 +0000 (-0700)
Subject: mon: make note about osd df calc bug
X-Git-Tag: v9.0.1~131^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=718faf0e6999eb2218b17ca712f5af922d0fed7f;p=ceph.git

mon: make note about osd df calc bug

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc
index 5c5ecaed58a62..7d8513b7df088 100644
--- a/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@ -625,6 +625,11 @@ public:
     max_var(-1),
     stddev(0),
     sum(0) {
+    // FIXME: average_util should be calculated from the same set of
+    // nodes that dump_item considers when calculating the stddev.  we
+    // probably need to make two tree traversals for that to work,
+    // maybe with a callback like precalc_item() that's looks similar
+    // to dump_item()?
     if (pgm->osd_sum.kb)
       average_util = 100.0 * (double)pgm->osd_sum.kb_used / (double)pgm->osd_sum.kb;
   }