From: Kyr Shatskyy Date: Wed, 15 Sep 2021 10:11:21 +0000 (+0200) Subject: orchestra/remote: throw exception on reconnect failed X-Git-Tag: 1.2.0~177^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=71de68bd6b61eb5d743ffffe5de698f66f5e9715;p=teuthology.git orchestra/remote: throw exception on reconnect failed In run method if a reconnect required there is a remote.reconnect method called which is supposed to return True or False. On failure it is the best to raise an exception early, to make it clear what was the original error instead of waiting until somewhere later teuthology fails with some undeclared variables. Signed-off-by: Kyr Shatskyy --- diff --git a/teuthology/orchestra/remote.py b/teuthology/orchestra/remote.py index 634ce7600..c7bbf172b 100644 --- a/teuthology/orchestra/remote.py +++ b/teuthology/orchestra/remote.py @@ -505,7 +505,8 @@ class Remote(RemoteShell): if not self.ssh or \ not self.ssh.get_transport() or \ not self.ssh.get_transport().is_active(): - self.reconnect() + if not self.reconnect(): + raise Exception(f'Cannot connect to remote host {self.shortname}') r = self._runner(client=self.ssh, name=self.shortname, **kwargs) r.remote = self return r