From: xie xingguo Date: Sat, 24 Jun 2017 04:09:17 +0000 (+0800) Subject: mon/OSDMonitor: kill dead code X-Git-Tag: v12.1.1~264^2~7 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=7438723389d66107d411ecc9858be50928f88661;p=ceph-ci.git mon/OSDMonitor: kill dead code This option is now filtered out automatically, so these codes are unaccessable. ./bin/ceph osd unset sortbitwise Invalid command: sortbitwise not in full|pause|noup|nodown|noout|noin|nobackfill|norebalance|norecover|noscrub|nodeep-scrub|notieragent osd unset full|pause|noup|nodown|noout|noin|nobackfill|norebalance|norecover|noscrub|nodeep-scrub|notieragent : unset Error EINVAL: invalid command Signed-off-by: xie xingguo --- diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc index 0555b9f8da9..e4e848556ef 100644 --- a/src/mon/OSDMonitor.cc +++ b/src/mon/OSDMonitor.cc @@ -8206,10 +8206,7 @@ bool OSDMonitor::prepare_command_impl(MonOpRequestRef op, return prepare_unset_flag(op, CEPH_OSDMAP_NODEEP_SCRUB); else if (key == "notieragent") return prepare_unset_flag(op, CEPH_OSDMAP_NOTIERAGENT); - else if (key == "sortbitwise") { - ss << "the sortbitwise flag is required and cannot be unset"; - err = -EPERM; - } else { + else { ss << "unrecognized flag '" << key << "'"; err = -EINVAL; }