From: Sage Weil Date: Mon, 23 Oct 2017 21:07:48 +0000 (-0500) Subject: mon/PGMap: 'unclean' does not imply damaged X-Git-Tag: v12.2.3~145^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7522ddd97845b8c2a15ad81a30b46a69e6f1444c;p=ceph.git mon/PGMap: 'unclean' does not imply damaged Everything (that I can think of) that would lead to a PG being unclean is already reported via another health message. And there are cases where a PG is unclean (e.g., because it is backfilling) where we are not degraded. Fix by ignoring this flag in the health checks. Signed-off-by: Sage Weil (cherry picked from commit 89e4cb90af3c193fe436390b5e3288701e6fc4af) --- diff --git a/src/mon/PGMap.cc b/src/mon/PGMap.cc index 6fcc3c0721af..a09caa4c8139 100644 --- a/src/mon/PGMap.cc +++ b/src/mon/PGMap.cc @@ -2672,8 +2672,7 @@ void PGMap::get_health_checks( { PG_STATE_UNDERSIZED, {DEGRADED, [](const pg_stat_t &p){return p.last_fullsized;} } }, { PG_STATE_STALE, {UNAVAILABLE, [](const pg_stat_t &p){return p.last_unstale;} } }, // Delayed and inverted reports - { PG_STATE_ACTIVE, {UNAVAILABLE, [](const pg_stat_t &p){return p.last_active;}, true} }, - { PG_STATE_CLEAN, {DEGRADED, [](const pg_stat_t &p){return p.last_clean;}, true} } + { PG_STATE_ACTIVE, {UNAVAILABLE, [](const pg_stat_t &p){return p.last_active;}, true} } }; // Specialized state printer that takes account of inversion of