From: Patrick Nawracay Date: Mon, 17 Jun 2019 11:01:33 +0000 (+0200) Subject: mgr/dashboard: Cleanup HACKING.rst X-Git-Tag: v15.1.0~2427^2~1 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=754e08017714543d71835c0deb3853603567f2b4;p=ceph-ci.git mgr/dashboard: Cleanup HACKING.rst Rephrase explanations on how to write E2E tests with Protractor. Signed-off-by: Patrick Nawracay --- diff --git a/src/pybind/mgr/dashboard/HACKING.rst b/src/pybind/mgr/dashboard/HACKING.rst index 6c1a2c2289f..ca31aa62156 100644 --- a/src/pybind/mgr/dashboard/HACKING.rst +++ b/src/pybind/mgr/dashboard/HACKING.rst @@ -139,13 +139,13 @@ There are a few ways how you can try to resolve this: Running End-to-End Tests ~~~~~~~~~~~~~~~~~~~~~~~~ -We use `Protractor `__ to run our frontend e2e +We use `Protractor `__ to run our frontend E2E tests. Our ``run-frontend-e2e-tests.sh`` script will check if Chrome or Docker is installed and run the tests if either is found. -Start all frontend e2e tests by running:: +Start all frontend E2E tests by running:: $ ./run-frontend-e2e-tests.sh @@ -173,12 +173,16 @@ Note: Writing End-to-End Tests ~~~~~~~~~~~~~~~~~~~~~~~~ -When writing e2e tests you don't want to recompile every time from scratch to -try out if your test has succeeded. As usual you have your development server -open (``npm start``) which already has compiled all files. To attach -`Protractor `__ to this process, instead of -spinning up it's own server, you can use ``npm run e2e -- --dev-server-target`` -or just ``npm run e2e:dev`` which is equivalent. +When writing E2E tests, it is not necessary to compile the frontend code on +each change of the test files. When your development environment is running +(``npm start``), you can point Protractor to just use this environment. To +attach `Protractor `__ to this process, run +``npm run e2e:dev``. + +Note:: + + In case you have a somewhat particular environment, you might need to adapt + `protractor.conf.js` to point to the appropriate destination. Further Help ~~~~~~~~~~~~