From: Alfredo Deza <adeza@redhat.com>
Date: Wed, 23 Aug 2017 17:44:46 +0000 (-0400)
Subject: ceph-volume tests create tests for the get_lv helper method
X-Git-Tag: v13.0.0~16^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7584d64c0fd585fd0e02991ccb9cad2d147fb130;p=ceph.git

ceph-volume tests create tests for the get_lv helper method

Signed-off-by: Alfredo Deza <adeza@redhat.com>
---

diff --git a/src/ceph-volume/ceph_volume/tests/devices/lvm/test_prepare.py b/src/ceph-volume/ceph_volume/tests/devices/lvm/test_prepare.py
index b8402a767559..fabae296a2b3 100644
--- a/src/ceph-volume/ceph_volume/tests/devices/lvm/test_prepare.py
+++ b/src/ceph-volume/ceph_volume/tests/devices/lvm/test_prepare.py
@@ -37,6 +37,21 @@ class TestPrepare(object):
         assert 'A logical group name or a path' in stdout
 
 
+class TestGetJournalLV(object):
+
+    @pytest.mark.parametrize('arg', ['', '///', None, '/dev/sda1'])
+    def test_no_journal_on_invalid_path(self, monkeypatch, arg):
+        monkeypatch.setattr(lvm.prepare.api, 'get_lv', lambda **kw: False)
+        prepare = lvm.prepare.Prepare([])
+        assert prepare.get_journal_lv(arg) is None
+
+    def test_no_journal_lv_found(self, monkeypatch):
+        # patch it with 0 so we know we are getting to get_lv
+        monkeypatch.setattr(lvm.prepare.api, 'get_lv', lambda **kw: 0)
+        prepare = lvm.prepare.Prepare([])
+        assert prepare.get_journal_lv('vg/lv') == 0
+
+
 class TestActivate(object):
 
     def test_main_spits_help_with_no_arguments(self, capsys):