From: Igor Fedotov Date: Wed, 11 Feb 2026 16:20:23 +0000 (+0300) Subject: os/bluestore: rename/repurpose bluefs_check_volume_selector_on_umount setting. X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=777783f4219d7e456d701b01463ec3419bf20873;p=ceph.git os/bluestore: rename/repurpose bluefs_check_volume_selector_on_umount setting. This is bluefs_check_volume_selector_on_mount now and enables volume selector validation on both mount and umount. Signed-off-by: Igor Fedotov --- diff --git a/src/common/options/global.yaml.in b/src/common/options/global.yaml.in index f3ebf1b1a8e..fe3021724f3 100644 --- a/src/common/options/global.yaml.in +++ b/src/common/options/global.yaml.in @@ -4351,10 +4351,10 @@ options: flags: - runtime with_legacy: true -- name: bluefs_check_volume_selector_on_umount +- name: bluefs_check_volume_selector_on_mount type: bool level: dev - desc: Check validity of volume selector on umount + desc: Check validity of volume selector on mount/umount long_desc: Checks if volume selector did not diverge from the state it should be in. Reference is constructed from bluefs inode table. Asserts on inconsistency. default: false @@ -4369,7 +4369,7 @@ options: Reference is constructed from bluefs inode table. Asserts on inconsistency. This is debug feature. default: false see_also: - - bluefs_check_volume_selector_on_umount + - bluefs_check_volume_selector_on_mount flags: - startup with_legacy: true diff --git a/src/os/bluestore/BlueFS.cc b/src/os/bluestore/BlueFS.cc index 0c173969d6b..3d855b467bd 100644 --- a/src/os/bluestore/BlueFS.cc +++ b/src/os/bluestore/BlueFS.cc @@ -1117,6 +1117,9 @@ int BlueFS::mount() _stop_alloc(); goto out; } + if (cct->_conf->bluefs_check_volume_selector_on_mount) { + _check_vselector_LNF(); + } conf_wal_envelope_mode = cct->_conf.get_val("bluefs_wal_envelope_mode"); log.uses_envelope_mode = conf_wal_envelope_mode; @@ -1201,7 +1204,7 @@ void BlueFS::umount(bool avoid_compact) dout(1) << __func__ << dendl; sync_metadata(avoid_compact); - if (cct->_conf->bluefs_check_volume_selector_on_umount) { + if (cct->_conf->bluefs_check_volume_selector_on_mount) { _check_vselector_LNF(); } _close_writer(log.writer); diff --git a/src/test/objectstore/store_test.cc b/src/test/objectstore/store_test.cc index c8d832c3a0d..9075aa08c40 100644 --- a/src/test/objectstore/store_test.cc +++ b/src/test/objectstore/store_test.cc @@ -12155,7 +12155,7 @@ int main(int argc, char **argv) { g_ceph_context->_conf.set_val_or_die("bluestore_debug_randomize_serial_transaction", "10"); - g_ceph_context->_conf.set_val_or_die("bluefs_check_volume_selector_on_umount", "true"); + g_ceph_context->_conf.set_val_or_die("bluefs_check_volume_selector_on_mount", "true"); g_ceph_context->_conf.set_val_or_die("bdev_debug_aio", "true"); g_ceph_context->_conf.set_val_or_die("log_max_recent", "10000");