From: Li Wang <liwang@ubuntukylin.com>
Date: Mon, 18 Nov 2013 07:40:19 +0000 (+0800)
Subject: mds: Release resource before return
X-Git-Tag: v0.74~66
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=784d1888a69cba681354493fcc20df4e8339d6c9;p=ceph.git

mds: Release resource before return

Close file before return.
Fix coverity issue: CID 1019571

Signed-off-by: Li Wang <liwang@ubuntukylin.com>
Reported-by: Xianxia Xiao <xianxiaxiao@ubuntukylin.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
---

diff --git a/src/mds/MDCache.cc b/src/mds/MDCache.cc
index ae59c26ee13b..17d4ce49188f 100644
--- a/src/mds/MDCache.cc
+++ b/src/mds/MDCache.cc
@@ -11731,7 +11731,7 @@ void MDCache::dump_cache(const char *fn)
     std::string s = ss.str();
     r = safe_write(fd, s.c_str(), s.length());
     if (r < 0)
-      return;
+      goto out;
 
     list<CDir*> dfs;
     in->get_dirfrags(dfs);