From: nsedrickm <nsedrick101@gmail.com>
Date: Mon, 29 Aug 2022 18:35:29 +0000 (+0100)
Subject: mgr/dashboard: remove duplicate ids from table column filters
X-Git-Tag: v18.0.0~77^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=78ec4addee07371cd8c86a91ec83dfe7324bd752;p=ceph-ci.git

mgr/dashboard: remove duplicate ids from table column filters

Generate random ids for column filters to avoid id conflics on pages with multiple tables sharing the same column filters

Signed-off-by: nsedrickm <nsedrick101@gmail.com>
Fixes: https://tracker.ceph.com/issues/55869
---

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.html b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.html
index 576a1cbe761..b73f0ad3973 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.html
@@ -114,10 +114,10 @@
                 <input class="custom-control-input"
                        type="checkbox"
                        [name]="column.prop"
-                       [id]="column.prop"
+                       id="{{ column.prop }}{{ tableName }}"
                        [checked]="!column.isHidden">
                 <label class="custom-control-label"
-                       [for]="column.prop">{{ column.name }}</label>
+                       for="{{ column.prop }}{{ tableName }}">{{ column.name }}</label>
               </div>
             </button>
           </ng-container>