From: Darrick J. Wong Date: Tue, 2 Jun 2026 04:59:21 +0000 (-0700) Subject: xfs_healer: fix Makefile errors X-Git-Tag: v7.1.0~70 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=79551362141a051faf9c3d504fe18ee34ca800f8;p=xfsprogs-dev.git xfs_healer: fix Makefile errors Codex had a couple of complaints about the makefile -- mostly that it never cleans up after xfs_healer_start; and that it should use LTINSTALL to install libtool binaries. Signed-off-by: "Darrick J. Wong" Reviewed-by: Christoph Hellwig --- diff --git a/healer/Makefile b/healer/Makefile index 1db28726..49a48b52 100644 --- a/healer/Makefile +++ b/healer/Makefile @@ -42,9 +42,12 @@ endif # HAVE_SYSTEMD ifeq ($(HAVE_HEALER_START_DEPS),yes) BUILD_TARGETS += xfs_healer_start +LDIRT += xfs_healer_start xfs_healer_start.o SYSTEMD_SERVICES += xfs_healer_start.service endif # xfs_healer_start deps +LDIRT += $(SYSTEMD_SERVICES) + default: depend $(BUILD_TARGETS) $(SYSTEMD_SERVICES) xfs_healer_start: $(SUBDIRS) xfs_healer_start.o $(LTDEPENDENCIES) @@ -62,7 +65,7 @@ install: $(INSTALL_HEALER) install-healer: default $(INSTALL) -m 755 -d $(PKG_LIBEXEC_DIR) - $(INSTALL) -m 755 $(BUILD_TARGETS) $(PKG_LIBEXEC_DIR) + $(LTINSTALL) -m 755 $(BUILD_TARGETS) $(PKG_LIBEXEC_DIR) install-systemd: default $(INSTALL) -m 755 -d $(SYSTEMD_SYSTEM_UNIT_DIR)