From: Greg Farnum <greg@inktank.com>
Date: Thu, 21 Feb 2013 22:30:42 +0000 (-0800)
Subject: MDS: remove a few other unnecessary is_base() checks
X-Git-Tag: v0.59~153
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=79f09bf33e3f4b6815d854fa0ce30b006b1e3e74;p=ceph.git

MDS: remove a few other unnecessary is_base() checks

We should let users remove xattrs as well as set them. ;) And
the check in handle_client_setlayout was totally useless -- perhaps
intended for setdirlayout?

This is a follow-on to 9f82ae60fac30391dfa9d17d2fc014bf9e21f387 and
should be taken wherever it goes.

Signed-off-by: Greg Farnum <greg@inktank.com>
---

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index 4f21601ebe81..38c7642bd7ca 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -3363,10 +3363,6 @@ void Server::handle_client_setlayout(MDRequest *mdr)
     reply_request(mdr, -EROFS);
     return;
   }
-  if(cur->is_base()) {
-    reply_request(mdr, -EINVAL);   // for now
-    return;
-  }
   if (cur->is_dir()) {
     reply_request(mdr, -EISDIR);
     return;
@@ -3855,10 +3851,6 @@ void Server::handle_client_removexattr(MDRequest *mdr)
     reply_request(mdr, -EROFS);
     return;
   }
-  if (cur->is_base()) {
-    reply_request(mdr, -EINVAL);   // for now
-    return;
-  }
 
   if (name.find("ceph.") == 0) {
     handle_remove_vxattr(mdr, cur, rdlocks, wrlocks, xlocks);