From: Nathan Cutler <ncutler@suse.com>
Date: Fri, 6 Sep 2019 21:38:46 +0000 (+0200)
Subject: script/ceph-backport.sh: check Backport ticket assignee
X-Git-Tag: v15.1.0~1586^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7b86b98185eb533a53dbd250b80f508e56f2fd10;p=ceph.git

script/ceph-backport.sh: check Backport ticket assignee

Don't work on tickets assigned to someone else.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
---

diff --git a/src/script/ceph-backport.sh b/src/script/ceph-backport.sh
index 5a45ceedeecd..17ec110c7258 100755
--- a/src/script/ceph-backport.sh
+++ b/src/script/ceph-backport.sh
@@ -514,6 +514,18 @@ fi
 tracker_title=$(echo $remote_api_output | jq -r '.issue.subject')
 debug "Title of $redmine_url is ->$tracker_title<-"
 
+tracker_assignee_id=$(echo $remote_api_output | jq -r '.issue.assigned_to.id')
+tracker_assignee_name=$(echo $remote_api_output | jq -r '.issue.assigned_to.name')
+debug "$redmine_url is assigned to $tracker_assignee_name (ID $tracker_assignee_id)"
+
+if [ "$tracker_assignee_id" = "null" -o "$tracker_assignee_id" = "$redmine_user_id" ] ; then
+    true
+else
+    error "$redmine_url is assigned to $tracker_assignee_name (ID $tracker_assignee_id)"
+    info "Cowardly refusing to work on an issue that is assigned to someone else"
+    false
+fi
+
 milestone_number=$(try_known_milestones "$milestone")
 if [ "$milestone_number" -gt "0" ] >/dev/null 2>&1 ; then
     target_branch="$milestone"
@@ -609,6 +621,6 @@ pgrep firefox >/dev/null && firefox ${github_endpoint}/pull/$number
 
 debug "Updating backport tracker issue in Redmine"
 redmine_status=2 # In Progress
-curl -X PUT --header 'Content-type: application/json' --data-binary '{"issue":{"description":"https://github.com/ceph/ceph/pull/'$number'","status_id":'$redmine_status',"assigned_to_id":'$redmine_user_id'}}' ${redmine_url}'.json?key='$redmine_key
+curl -X PUT --header 'Content-type: application/json' --data-binary '{"issue":{"description":"https://github.com/ceph/ceph/pull/'$number'","status_id":'$redmine_status',"assigned_to_id":'$redmine_user_id'},"notes":"Updated automatically by ceph-backport.sh"}' ${redmine_url}'.json?key='$redmine_key
 info "${redmine_url} updated"
 pgrep firefox >/dev/null && firefox ${redmine_url}