From: Kefu Chai <kchai@redhat.com>
Date: Thu, 28 Dec 2017 02:18:11 +0000 (+0800)
Subject: install-deps.sh: check if have access to stdout
X-Git-Tag: v13.0.2~668^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7bb8f66cf4e2519c33f1078c1be7485f9fe35a87;p=ceph.git

install-deps.sh: check if have access to stdout

$- is "hB" if launched via command line, and it is "himBH" only when
we are actually *in* an interactive shell. so checking "test -t 1" is
what we want.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/install-deps.sh b/install-deps.sh
index 336a156dfd7d..ef55b056a947 100755
--- a/install-deps.sh
+++ b/install-deps.sh
@@ -80,10 +80,9 @@ function ensure_decent_gcc_on_rh {
     local expected=5.1
     local dts_ver=$1
     if version_lt $old $expected; then
-	case $- in
-	    *i*)
-		# interactive shell
-		cat <<EOF
+	if test -t 1; then
+	    # interactive shell
+	    cat <<EOF
 Your GCC is too old. Please run following command to add DTS to your environment:
 
 scl enable devtoolset-7 bash
@@ -94,12 +93,10 @@ source scl_source enable devtoolset-7
 
 see https://www.softwarecollections.org/en/scls/rhscl/devtoolset-7/ for more details.
 EOF
-	    ;;
-	    *)
-		# non-interactive shell
-		source /opt/rh/devtoolset-$dts_ver/enable
-		;;
-	esac
+	else
+	    # non-interactive shell
+	    source /opt/rh/devtoolset-$dts_ver/enable
+	fi
     fi
 }