From: Peter Dillinger <peterd@fb.com>
Date: Mon, 13 Sep 2021 19:16:51 +0000 (-0700)
Subject: Bypass unused parameterization in ExternalSSTFileBasicTest.IngestExte… (#8910)
X-Git-Tag: v6.25.1~32
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7bef598440ee18d4bd53635ee64ce783003c9d6d;p=rocksdb.git

Bypass unused parameterization in ExternalSSTFileBasicTest.IngestExte… (#8910)

Summary:
Facebook infrastructure doesn't like continuously skipping
tests, so fixing this permanently disabled parameterization to BYPASS
instead of SKIP. (Internal ref: T100525285)

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8910

Test Plan: manual

Reviewed By: anand1976

Differential Revision: D30905169

Pulled By: pdillinger

fbshipit-source-id: e23d63d2aa800e54676269fad3a093cd3f9f222d
---

diff --git a/db/external_sst_file_basic_test.cc b/db/external_sst_file_basic_test.cc
index 71c2f7bce..a006a817d 100644
--- a/db/external_sst_file_basic_test.cc
+++ b/db/external_sst_file_basic_test.cc
@@ -1524,7 +1524,11 @@ TEST_P(ExternalSSTFileBasicTest, IngestFileWithFirstByteTampered) {
 
 TEST_P(ExternalSSTFileBasicTest, IngestExternalFileWithCorruptedPropsBlock) {
   bool verify_checksums_before_ingest = std::get<1>(GetParam());
-  if (!verify_checksums_before_ingest || !random_rwfile_supported_) {
+  if (!verify_checksums_before_ingest) {
+    ROCKSDB_GTEST_BYPASS("Bypassing test when !verify_checksums_before_ingest");
+    return;
+  }
+  if (!random_rwfile_supported_) {
     ROCKSDB_GTEST_SKIP("Test requires NewRandomRWFile support");
     return;
   }