From: Donald Douwsma Date: Wed, 18 Jun 2008 16:08:20 +0000 (+0000) Subject: Fix XFSQA test 144 X-Git-Tag: v1.1.0~374 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7d8939d27c37e92dcac3b75c1dff9830870186c8;p=xfstests-dev.git Fix XFSQA test 144 Two really dumb bugs: - "foo & 0x3FFFFFFFFFFFF" doesn't cap at 1TB, but rather at more than two magnitudes larger than that. That gets us EFBIG with typical 32bit XFS setups. - the command array can easily overflow and thus let the test fail Signed-off-by: Christoph Hellwig Merge of master-melb:xfs-cmds:31327a by kenmcd. Fix XFSQA test 144 --- diff --git a/dmapi/src/suite2/src/test_fileattr.c b/dmapi/src/suite2/src/test_fileattr.c index 446c3806..520fc8de 100644 --- a/dmapi/src/suite2/src/test_fileattr.c +++ b/dmapi/src/suite2/src/test_fileattr.c @@ -160,7 +160,7 @@ main( char *ls_path; char *pathname; char test_file[100]; - char command[100]; + char command[200]; int num_files=50; dm_stat_t *stat_arr; dm_stat_t dmstat; @@ -244,7 +244,7 @@ main( stat_arr[i].dt_uid=(uid_t)(rand()+rand()*0x10000); stat_arr[i].dt_gid=(gid_t)(rand()+rand()*0x10000); stat_arr[i].dt_mode=(mode_t)((rand()%4096)+32768); - stat_arr[i].dt_size=((dm_off_t)(rand()+rand()*0x10000)) & 0x3FFFFFFFFFFFF; /* 1 TB max */ + stat_arr[i].dt_size=((dm_off_t)(rand()+rand()*0x10000)) & 0x1FFFFFFFFFFULL; /* 1 TB max */ } /*-----------------------------------------------------*\