From: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Date: Fri, 27 Sep 2019 17:38:33 +0000 (+0200)
Subject: bloom-filter: Remove POD overloads for insert and contains
X-Git-Tag: v15.1.0~1380^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=7e2b15374c2b639942e75b05253f6dff1ff62697;p=ceph-ci.git

bloom-filter: Remove POD overloads for insert and contains

These are not used in Ceph code currently, and should not
be used in the future either, since any use will introduce
byte-order dependent behavior.  Remove them to prevent
accidental use.

Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
---

diff --git a/src/common/bloom_filter.hpp b/src/common/bloom_filter.hpp
index 3cd9d4151ee..e468275a7b6 100644
--- a/src/common/bloom_filter.hpp
+++ b/src/common/bloom_filter.hpp
@@ -180,13 +180,6 @@ public:
     ++insert_count_;
   }
 
-  template<typename T>
-  inline void insert(const T& t)
-  {
-    // Note: T must be a C++ POD type.
-    insert(reinterpret_cast<const unsigned char*>(&t),sizeof(T));
-  }
-
   inline void insert(const std::string& key)
   {
     insert(reinterpret_cast<const unsigned char*>(key.c_str()),key.size());
@@ -251,12 +244,6 @@ public:
     return true;
   }
 
-  template<typename T>
-  inline bool contains(const T& t) const
-  {
-    return contains(reinterpret_cast<const unsigned char*>(&t),static_cast<std::size_t>(sizeof(T)));
-  }
-
   inline bool contains(const std::string& key) const
   {
     return contains(reinterpret_cast<const unsigned char*>(key.c_str()),key.size());