From: Zack Cerza Date: Wed, 1 Apr 2020 19:02:03 +0000 (-0600) Subject: dashboards: Fix broken disk latency chart X-Git-Tag: v2.0.10~1^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7e4411c9f778b86ccc5be44c793a2f8a13cb6154;p=cephmetrics.git dashboards: Fix broken disk latency chart The "All OSD Hosts - Highest Latency" chart's query was missing a parenthesis, throwing numbers off by large amounts. Resolves: rhbz#1650209 Signed-off-by: Zack Cerza --- diff --git a/dashboards/mgr-prometheus/latency-by-server.json b/dashboards/mgr-prometheus/latency-by-server.json index 61260e5..32f9623 100644 --- a/dashboards/mgr-prometheus/latency-by-server.json +++ b/dashboards/mgr-prometheus/latency-by-server.json @@ -90,7 +90,7 @@ "steppedLine": false, "targets": [ { - "expr": "max(\n (irate(node_disk_read_time_ms[30s]) + irate(node_disk_write_time_ms[30s]) / \n (irate(node_disk_reads_completed[30s]) + irate(node_disk_writes_completed[30s])) +\n ignoring(ceph_daemon,job,wal_device) ceph_disk_occupation))\n by(instance)", + "expr": "max(\n (\n (irate(node_disk_read_time_ms[30s]) + irate(node_disk_write_time_ms[30s])) / \n (irate(node_disk_reads_completed[30s]) + irate(node_disk_writes_completed[30s])) +\n ignoring(ceph_daemon,job,wal_device) ceph_disk_occupation\n )\n) by(instance)", "format": "time_series", "intervalFactor": 1, "legendFormat": "{{instance}}",