From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Thu, 18 Sep 2014 11:28:47 +0000 (+0200)
Subject: test/kv_store_bench.cc: fix coverity REVERSE_INULL
X-Git-Tag: v0.88~166^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7e829509fe294e8d0207ae1e07182772bf7c3ede;p=ceph.git

test/kv_store_bench.cc: fix coverity REVERSE_INULL

CID 1021214 (#1 of 1): Dereference before null check (REVERSE_INULL)
 check_after_deref: Null-checking cb_args suggests that it may be
 null, but it has already been dereferenced on all paths leading to
 the check.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/test/kv_store_bench.cc b/src/test/kv_store_bench.cc
index 698105c9f39b..790e5695fcb0 100644
--- a/src/test/kv_store_bench.cc
+++ b/src/test/kv_store_bench.cc
@@ -420,9 +420,7 @@ int KvStoreBench::test_teuthology_aio(next_gen_t distr,
       break;
     }
 
-    if (cb_args) {
-      delete cb_args;
-    }
+    delete cb_args;
   }
 
   while(ops_in_flight > 0) {