From: Rodrigo Campos <rodrigo@sdfg.com.ar>
Date: Tue, 14 Mar 2023 11:45:03 +0000 (+0100)
Subject: vfs: Don't open-code safe_close()
X-Git-Tag: v2023.03.19~11
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=7f1135469db74aeaa67bb6d528ba92ffc190b40d;p=xfstests-dev.git

vfs: Don't open-code safe_close()

Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Zorro Lang <zlang@kernel.org>
---

diff --git a/src/vfs/utils.c b/src/vfs/utils.c
index 8b000506..ea7536c1 100644
--- a/src/vfs/utils.c
+++ b/src/vfs/utils.c
@@ -129,10 +129,8 @@ static int write_id_mapping(idmap_type_t map_type, pid_t pid, const char *buf, s
 
 	fret = 0;
 out:
-	if (fd >= 0)
-		close(fd);
-	if (setgroups_fd >= 0)
-		close(setgroups_fd);
+	safe_close(fd);
+	safe_close(setgroups_fd);
 
 	return fret;
 }