From: Adam King Date: Mon, 12 Aug 2024 14:10:42 +0000 (-0400) Subject: python-common/service_spec: fix zonegroup_hostnames type X-Git-Tag: v20.0.0~1035^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=7f2324fb5f27901c3c07abb7623e121608d28fbc;p=ceph.git python-common/service_spec: fix zonegroup_hostnames type This was meant to be a list of strings. The only use for it was passing it to the rgw module with a mon_command call so mypy didn't notice. New work to use this field for custom SANs entries into self-signed certs revealed the issue Signed-off-by: Adam King --- diff --git a/src/python-common/ceph/deployment/service_spec.py b/src/python-common/ceph/deployment/service_spec.py index a69b3a25dcd3..7853df6b554b 100644 --- a/src/python-common/ceph/deployment/service_spec.py +++ b/src/python-common/ceph/deployment/service_spec.py @@ -1221,7 +1221,7 @@ class RGWSpec(ServiceSpec): rgw_realm_token: Optional[str] = None, update_endpoints: Optional[bool] = False, zone_endpoints: Optional[str] = None, # comma separated endpoints list - zonegroup_hostnames: Optional[str] = None, + zonegroup_hostnames: Optional[List[str]] = None, rgw_user_counters_cache: Optional[bool] = False, rgw_user_counters_cache_size: Optional[int] = None, rgw_bucket_counters_cache: Optional[bool] = False,