From: Darrick J. Wong <djwong@kernel.org>
Date: Mon, 7 Apr 2025 23:59:31 +0000 (-0700)
Subject: common/rc: fix dumping of corrupt ext* filesystems
X-Git-Tag: v2025.04.13~15
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=7ff687d857475134611fbba98b1ab00db025784d;p=xfstests-dev.git

common/rc: fix dumping of corrupt ext* filesystems

The parameters to _ext4_metadump are device, dumpfile, and compress
options.  This callsite got the arguments in the wrong order, which
causes fstests to compress all of /dev/sdX as /dev/sdX.zst which is not
what we want.

Cc: fstests@vger.kernel.org # v2022.05.01
Fixes: 9fb30a9500c169 ("common: capture qcow2 dumps of corrupt ext* filesystems")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>
---

diff --git a/common/rc b/common/rc
index 16d627e1..7c333f7f 100644
--- a/common/rc
+++ b/common/rc
@@ -3496,7 +3496,7 @@ _check_generic_filesystem()
         case "$FSTYP" in
         ext*)
             local flatdev="$(basename "$device")"
-            _ext4_metadump "$seqres.$flatdev.check.qcow2" "$device" compress
+            _ext4_metadump "$device" "$seqres.$flatdev.check.qcow2" compress
             ;;
         esac
     fi