From: Neha Ojha Date: Mon, 11 Nov 2019 21:32:15 +0000 (-0800) Subject: osd/OSDMap.cc: don't output over/underfull messages to lderr X-Git-Tag: v13.2.9~112^2~12 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=802718e30cc5b09982dbde7da0a3baf94465fec8;p=ceph.git osd/OSDMap.cc: don't output over/underfull messages to lderr There can be cases where overfull and underfull(see example in https://tracker.ceph.com/issues/42756) will be empty, which is not necessarily an error. These error messages can end up spamming the ceph-mgr log. Fixes: https://tracker.ceph.com/issues/42756 Signed-off-by: Neha Ojha (cherry picked from commit 3cf28f09a2ebdd922fc5c1d29c65469f8331e741) --- diff --git a/src/osd/OSDMap.cc b/src/osd/OSDMap.cc index 41c18e2674b..12b10c5db3a 100644 --- a/src/osd/OSDMap.cc +++ b/src/osd/OSDMap.cc @@ -4265,7 +4265,7 @@ int OSDMap::calc_pg_upmaps( overfull.insert(i->second); } if (overfull.empty()) { - lderr(cct) << __func__ << " failed to build overfull" << dendl; + ldout(cct, 20) << __func__ << " failed to build overfull" << dendl; break; } @@ -4277,7 +4277,7 @@ int OSDMap::calc_pg_upmaps( underfull.push_back(i->second); } if (underfull.empty()) { - lderr(cct) << __func__ << " failed to build underfull" << dendl; + ldout(cct, 20) << __func__ << " failed to build underfull" << dendl; break; }