From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Fri, 2 Oct 2020 11:43:47 +0000 (+0200)
Subject: lint: do not use 'local_action'
X-Git-Tag: v5.0.3~7
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=805183bde3f37ca179caed8b3226cf413ee07bc4;p=ceph-ansible.git

lint: do not use 'local_action'

Fix ansible-lint 504 error:

[504] Do not use 'local_action', use 'delegate_to: localhost'

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit c948b668ebe7cf7af61090ac6f9b93e0a16e14ee)
---

diff --git a/infrastructure-playbooks/gather-ceph-logs.yml b/infrastructure-playbooks/gather-ceph-logs.yml
index ac9802400..95c0a26ba 100644
--- a/infrastructure-playbooks/gather-ceph-logs.yml
+++ b/infrastructure-playbooks/gather-ceph-logs.yml
@@ -15,13 +15,13 @@
 
   tasks:
     - name: create a temp directory
-      local_action:
-        module: tempfile
+      tempfile:
         state: directory
         prefix: ceph_ansible
       run_once: true
       register: localtempfile
       become: false
+      delegate_to: localhost
 
     - name: set_fact lookup_ceph_config - lookup keys, conf and logs
       find:
diff --git a/infrastructure-playbooks/purge-cluster.yml b/infrastructure-playbooks/purge-cluster.yml
index b884f6b1b..d4206671e 100644
--- a/infrastructure-playbooks/purge-cluster.yml
+++ b/infrastructure-playbooks/purge-cluster.yml
@@ -366,13 +366,13 @@
 
   - name: wait for server to boot
     become: false
-    local_action:
-      module: wait_for
+    wait_for:
       port: 22
       host: "{{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }}"
       state: started
       delay: 10
       timeout: 500
+      delegate_to: localhost
 
   - name: remove data
     shell: rm -rf /var/lib/ceph/*
@@ -444,9 +444,8 @@
     ignore_errors: true
 
   - name: is reboot needed
-    local_action:
-      module: command
-        echo requesting reboot
+    command: echo requesting reboot
+    delegate_to: localhost
     become: false
     notify:
       - restart machine
@@ -827,10 +826,9 @@
      state: absent
 
   - name: request data removal
-    local_action:
-      module: command
-        echo requesting data removal  # noqa 301
+    command: echo requesting data removal  # noqa 301
     become: false
+    delegate_to: localhost
     notify: remove data
 
   - name: purge dnf cache