From: Radoslaw Zarzynski Date: Wed, 16 Jul 2025 12:04:00 +0000 (+0000) Subject: crimson/osd: fix unused variable warnings pg.cc and seastore X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=80972d9e12ee4180cd0e125987a50d625eb90199;p=ceph-ci.git crimson/osd: fix unused variable warnings pg.cc and seastore Signed-off-by: Radoslaw Zarzynski --- diff --git a/src/crimson/os/seastore/transaction.h b/src/crimson/os/seastore/transaction.h index 4541eb56e4e..61a6f4bff70 100644 --- a/src/crimson/os/seastore/transaction.h +++ b/src/crimson/os/seastore/transaction.h @@ -710,7 +710,7 @@ private: // step 2: attach extent to transaction to become visible assert(!read_set.count(ref->get_paddr(), extent_cmp_t{})); - auto [iter, inserted] = read_set.insert(*it); + [[maybe_unused]] auto [iter, inserted] = read_set.insert(*it); assert(inserted); } @@ -729,7 +729,7 @@ private: } // step 2: attach extent to transaction to become visible - auto [iter, inserted] = read_set.insert(read_items.back()); + [[maybe_unused]] auto [iter, inserted] = read_set.insert(read_items.back()); assert(inserted); // added diff --git a/src/crimson/osd/pg.cc b/src/crimson/osd/pg.cc index 675de1877b0..15329936287 100644 --- a/src/crimson/osd/pg.cc +++ b/src/crimson/osd/pg.cc @@ -675,7 +675,7 @@ void PG::on_active_advmap(const OSDMapRef &osdmap) const auto new_removed_snaps = osdmap->get_new_removed_snaps(); if (auto it = new_removed_snaps.find(get_pgid().pool()); it != new_removed_snaps.end()) { - bool bad = false; + [[maybe_unused]] bool bad = false; for (auto j : it->second) { if (snap_trimq.intersects(j.first, j.second)) { decltype(snap_trimq) added, overlap; @@ -1321,7 +1321,8 @@ void PG::check_blocklisted_obc_watchers( auto watch = crimson::osd::Watch::create( obc, winfo, src.second, this); watch->disconnect(); - auto [it, emplaced] = obc->watchers.emplace(src, std::move(watch)); + [[maybe_unused]] auto [it, emplaced] = + obc->watchers.emplace(src, std::move(watch)); assert(emplaced); logger().debug("added watch for obj {}, client {}", obc->get_oid(), src.second);