From: Sage Weil <sage@redhat.com>
Date: Thu, 21 Sep 2017 19:19:47 +0000 (-0400)
Subject: osd: make shutdown debug conditional (and off by default)
X-Git-Tag: v12.2.2~167^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=80f6508fc25018dd9c70d05f99c40325062d129e;p=ceph.git

osd: make shutdown debug conditional (and off by default)

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 6169cf64423c7554dc0630d90d8dee27437bf05f)
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 0be052e1bc5..aa493482ddf 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -2580,6 +2580,10 @@ std::vector<Option> get_global_options() {
     .set_default(false)
     .set_description(""),
 
+    Option("osd_debug_shutdown", Option::TYPE_BOOL, Option::LEVEL_DEV)
+    .set_default(false)
+    .set_description("Turn up debug levels during shutdown"),
+
     Option("osd_debug_crash_on_ignored_backoff", Option::TYPE_BOOL, Option::LEVEL_DEV)
     .set_default(false)
     .set_description(""),
diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index 8056e6283f1..e70930f75c1 100644
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -3250,12 +3250,14 @@ int OSD::shutdown()
   set_state(STATE_STOPPING);
 
   // Debugging
-  cct->_conf->set_val("debug_osd", "100");
-  cct->_conf->set_val("debug_journal", "100");
-  cct->_conf->set_val("debug_filestore", "100");
-  cct->_conf->set_val("debug_bluestore", "100");
-  cct->_conf->set_val("debug_ms", "100");
-  cct->_conf->apply_changes(NULL);
+  if (cct->_conf->get_val<bool>("osd_debug_shutdown")) {
+    cct->_conf->set_val("debug_osd", "100");
+    cct->_conf->set_val("debug_journal", "100");
+    cct->_conf->set_val("debug_filestore", "100");
+    cct->_conf->set_val("debug_bluestore", "100");
+    cct->_conf->set_val("debug_ms", "100");
+    cct->_conf->apply_changes(NULL);
+  }
 
   // stop MgrClient earlier as it's more like an internal consumer of OSD
   mgrc.shutdown();