From: Sage Weil <sage@redhat.com>
Date: Mon, 28 Nov 2016 18:45:35 +0000 (-0500)
Subject: os/bluestore/BlueFS: check flush result
X-Git-Tag: v11.1.0~120^2~10
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=81de672a6742268a42c62628cfddd058616fd7e4;p=ceph.git

os/bluestore/BlueFS: check flush result

CID 1394759 (#1 of 1): Unchecked return value (CHECKED_RETURN)
20. check_return: Calling _flush without checking return value (as is done elsewhere 4 out of 5 times).

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/os/bluestore/BlueFS.cc b/src/os/bluestore/BlueFS.cc
index 9d32697343f..8df7e712903 100644
--- a/src/os/bluestore/BlueFS.cc
+++ b/src/os/bluestore/BlueFS.cc
@@ -1178,7 +1178,8 @@ void BlueFS::_compact_log_async(std::unique_lock<std::mutex>& l)
   new_log_writer->append(bl);
 
   // 3. flush
-  _flush(new_log_writer, true);
+  r = _flush(new_log_writer, true);
+  assert(r == 0);
   lock.unlock();
 
   // 4. wait