From: Afreen Misbah Date: Wed, 8 Jul 2026 04:47:38 +0000 (+0530) Subject: Merge pull request #69917 from rhcs-dashboard/edit-host-access X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=84881e99f0756fbd6f69ef604ce6ecf5ef660d6c;p=ceph.git Merge pull request #69917 from rhcs-dashboard/edit-host-access mgr/dashboard: NVMe-oF – Enable editing host access from the Subsystem Overview page Reviewed-by: Afreen Misbah --- 84881e99f0756fbd6f69ef604ce6ecf5ef660d6c diff --cc src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-group-form/nvmeof-group-form.component.ts index dd54c824f19,583626b7bd1..f5226f1c40b --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-group-form/nvmeof-group-form.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-group-form/nvmeof-group-form.component.ts @@@ -67,21 -55,20 +67,22 @@@ export class NvmeofGroupFormComponent e } createForm() { + const groupNameValidators = [ + Validators.required, + (control: any) => { + const value = control.value; + return value && /[^a-zA-Z0-9_-]/.test(value) ? { invalidChars: true } : null; + } + ]; + + const groupNameAsyncValidators = this.editing + ? [] + : [CdValidators.unique(this.nvmeofService.exists, this.nvmeofService)]; + this.groupForm = new CdFormGroup({ - groupName: new UntypedFormControl( - null, - [ - Validators.required, - (control) => { - const value = control.value; - return value && /[^a-zA-Z0-9_-]/.test(value) ? { invalidChars: true } : null; - } - ], - [CdValidators.unique(this.nvmeofService.exists, this.nvmeofService)] - ), + groupName: new UntypedFormControl(null, groupNameValidators, groupNameAsyncValidators), unmanaged: new UntypedFormControl(false), + enable_auth: new UntypedFormControl(false), enableEncryption: new UntypedFormControl(false), encryptionConfig: new UntypedFormControl(null), encryptionKey: new UntypedFormControl(null),