From: neeraj pratap singh <neerajpratapsingh@li-ff7f0d4c-3462-11b2-a85c-d4004c0fa1a0.ibm.com>
Date: Mon, 24 Feb 2025 15:13:01 +0000 (+0530)
Subject: mds: add a proper check to evict clients with id 0
X-Git-Tag: v21.0.0~10^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=84b0a0dcb9a8786feb52297911f845cfbb22ffaa;p=ceph.git

mds: add a proper check to evict clients with id 0

Fixes: https://tracker.ceph.com/issues/70198
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
---

diff --git a/src/mds/SessionMap.cc b/src/mds/SessionMap.cc
index 95daccac2ec..3aa3969d294 100644
--- a/src/mds/SessionMap.cc
+++ b/src/mds/SessionMap.cc
@@ -1303,10 +1303,16 @@ int SessionFilter::parse(
       if (v == "*") {
         // evict all clients , by default id set to 0
         return 0;
-      } else if (v == "0") {
-        *ss << "Invalid value";
-        return -EINVAL;
-      }
+      } else {
+        try {
+          if (!std::stoi(v)) {
+            *ss << "Invalid value";
+            return -EINVAL; } 
+          } catch (...) {
+            *ss << "Invalid input";
+            return -EINVAL;
+          }
+        }
       id = strict_strtoll(v.c_str(), 10, &err);
       if (!err.empty()) {
         *ss << err;