From: Kefu Chai Date: Wed, 16 Jun 2021 11:58:42 +0000 (+0800) Subject: crimson/os: use reference for loop variable X-Git-Tag: v17.1.0~1631^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=84c71bc22fba344eb47db72ed9e29f11163c2638;p=ceph.git crimson/os: use reference for loop variable for better performance, also silences the warning like: ../src/crimson/os/seastore/random_block_manager/nvme_manager.cc:444:23: warning: loop variable ‘b’ creates a copy from type ‘const crimson::os::seastore::rbm_alloc_delta_t’ [-Wrange-loop-construct] 444 | for (const auto b : alloc_blocks) { | ^ Signed-off-by: Kefu Chai --- diff --git a/src/crimson/os/seastore/random_block_manager/nvme_manager.cc b/src/crimson/os/seastore/random_block_manager/nvme_manager.cc index 989c7864b2f7..8326162b8662 100644 --- a/src/crimson/os/seastore/random_block_manager/nvme_manager.cc +++ b/src/crimson/os/seastore/random_block_manager/nvme_manager.cc @@ -441,7 +441,7 @@ NVMeManager::write_ertr::future<> NVMeManager::sync_allocation( }); }).safe_then([this, &alloc_blocks]() mutable { int alloc_block_count = 0; - for (const auto b : alloc_blocks) { + for (const auto& b : alloc_blocks) { for (interval_set::const_iterator r = b.alloc_blk_ids.begin(); r != b.alloc_blk_ids.end(); ++r) { if (b.op == rbm_alloc_delta_t::op_types_t::SET) {