From: Nathan Cutler Date: Sat, 6 Jun 2015 13:16:16 +0000 (+0200) Subject: SubmittingPatches: clarify how Reviewed-by lines are added X-Git-Tag: v9.0.2~34^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=85b327f85aa3ccc2a766d201ddaead95b246ff20;p=ceph.git SubmittingPatches: clarify how Reviewed-by lines are added Signed-off-by: Nathan Cutler --- diff --git a/SubmittingPatches b/SubmittingPatches index 6b2ff980fe2c..4831215a8758 100644 --- a/SubmittingPatches +++ b/SubmittingPatches @@ -273,6 +273,15 @@ A: The target branch depends on the nature of your change: you are fixing a bug that exists on the "firefly" branch and that you desire that your change be cherry-picked to that branch. +Q: How to include Reviewed-by: tag(s) in my pull request? + + You don't. If someone reviews your pull request, they should indicate they + have done so by commenting on it with "+1", "looks good to me", "LGTM", + and/or the entire "Reviewed-by: ..." line with their name and email address. + + The developer merging the pull request should note positive reviews and + include the appropriate Reviewed-by: lines in the merge commit. + 2) Patch submission via ceph-devel@vger.kernel.org The best way to generate a patch for manual submission is to work from