From: Patrick Donnelly <pdonnell@redhat.com>
Date: Wed, 29 Mar 2023 13:05:25 +0000 (-0400)
Subject: mds: add config to decide whether to mark dentry bad
X-Git-Tag: v16.2.13~55^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=85bfda3268ce14c3b034d5b8a5c659caae8f8688;p=ceph.git

mds: add config to decide whether to mark dentry bad

So admin can restore access to files if necessary.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 7ffa065a03316b67b6b6d48692b4b181f93ddbda)
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 8b2ff9872281..381b693983d7 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -8688,6 +8688,11 @@ std::vector<Option> get_mds_options() {
     .set_default(true)
     .set_description("MDS will abort if dentry is detected newly corrupted."),
 
+    Option("mds_go_bad_corrupt_dentry", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
+    .set_default(true)
+    .set_flag(Option::FLAG_RUNTIME)
+    .set_description("MDS will mark a corrupt dentry as bad and isolate"),
+
     Option("mds_inject_rename_corrupt_dentry_first", Option::TYPE_FLOAT, Option::LEVEL_DEV)
     .set_default(0.0)
     .set_flag(Option::FLAG_RUNTIME)
diff --git a/src/mds/CDentry.cc b/src/mds/CDentry.cc
index e6f7b5e54221..a2a7985996a8 100644
--- a/src/mds/CDentry.cc
+++ b/src/mds/CDentry.cc
@@ -689,7 +689,9 @@ bool CDentry::check_corruption(bool load)
     } else {
       derr << "newly corrupt dentry to be committed: " << *this << dendl;
     }
-    dir->go_bad_dentry(last, get_name());
+    if (g_conf().get_val<bool>("mds_go_bad_corrupt_dentry")) {
+      dir->go_bad_dentry(last, get_name());
+    }
     if (!load && g_conf().get_val<bool>("mds_abort_on_newly_corrupt_dentry")) {
       dir->mdcache->mds->clog->error() << "MDS abort because newly corrupt dentry to be committed: " << *this;
       ceph_abort("detected newly corrupt dentry"); /* avoid writing out newly corrupted dn */