From: Kefu Chai Date: Wed, 9 Sep 2020 02:17:28 +0000 (+0800) Subject: crimson/net: do not print non-void* pointer X-Git-Tag: v16.1.0~1157^2~8 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=86e9b6887f9472cea68b4caf511d8c5b1f4afc74;p=ceph.git crimson/net: do not print non-void* pointer to address the failure like fmt/core.h:902:19: error: static assertion failed: formatting of non-void pointers is disallowed 902 | static_assert(!sizeof(T), "formatting of non-void pointers is disallowed"); | ^~~~~~~~~~ and i searched around, couldn't find any other statement printing the address of message, so i think it's not of much use to print their addresses in a single place, unless we can cross check them in different places. Signed-off-by: Kefu Chai --- diff --git a/src/crimson/net/ProtocolV2.cc b/src/crimson/net/ProtocolV2.cc index fd9567be9949..750f458bd9df 100644 --- a/src/crimson/net/ProtocolV2.cc +++ b/src/crimson/net/ProtocolV2.cc @@ -1908,8 +1908,8 @@ seastar::future<> ProtocolV2::read_message(utime_t throttle_stamp) // elsewhere. in that case it doesn't matter if we "got" it or not. uint64_t cur_seq = conn.in_seq; if (message->get_seq() <= cur_seq) { - logger().error("{} got old message {} <= {} {} {}, discarding", - conn, message->get_seq(), cur_seq, message, *message); + logger().error("{} got old message {} <= {} {}, discarding", + conn, message->get_seq(), cur_seq, *message); if (HAVE_FEATURE(conn.features, RECONNECT_SEQ) && local_conf()->ms_die_on_old_message) { ceph_assert(0 == "old msgs despite reconnect_seq feature");