From: Patrick Seidensal <pseidensal@suse.com>
Date: Fri, 13 Sep 2019 10:10:05 +0000 (+0200)
Subject: mgr/dashboard: add smart self report summary to details of osd-smart-list
X-Git-Tag: v15.1.0~1350^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=87136e61b27ec82008c5144145a3043342edd614;p=ceph-ci.git

mgr/dashboard: add smart self report summary to details of osd-smart-list

Fixes: https://tracker.ceph.com/issues/41774

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
---

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.html
index d5e3fe1688a..31a7bb8374c 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.html
@@ -9,6 +9,24 @@
           <cd-alert-panel type="warning">{{ device.value.userMessage }}</cd-alert-panel>
         </ng-container>
         <ng-template #noError>
+          <ng-container *ngIf="device.value.smart.data.self_test.status.passed; else selfTestFailed">
+            <cd-alert-panel
+              size="slim"
+              type="info"
+              i18n-title
+              title="SMART overall-health self-assessment test result">
+              {{ device.value.smart.data.self_test.status.string }}
+            </cd-alert-panel>
+          </ng-container>
+          <ng-template #selfTestFailed>
+            <cd-alert-panel
+              size="slim"
+              type="warning"
+              i18n-title
+              title="SMART overall-health self-assessment test result">
+              {{ device.value.smart.data.self_test.status.string }}
+            </cd-alert-panel>
+          </ng-template>
           <tabset>
             <tab i18n-heading
                  heading="Device Information">
@@ -18,7 +36,7 @@
 
             <tab i18n-heading
                  heading="S.M.A.R.T">
-              <cd-table [data]="device.value.smart.table"
+              <cd-table [data]="device.value.smart.attributes.table"
                         updateSelectionOnRefresh="never"
                         [columns]="columns"></cd-table>
             </tab>
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.spec.ts
index c003d68e67e..826728477c4 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.spec.ts
@@ -1,7 +1,8 @@
 import { HttpClientTestingModule } from '@angular/common/http/testing';
 import { SimpleChange, SimpleChanges } from '@angular/core';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
-import { TabsModule } from 'ngx-bootstrap/tabs';
+import { By } from '@angular/platform-browser';
+import { TabsetComponent, TabsetConfig, TabsModule } from 'ngx-bootstrap/tabs';
 
 import _ = require('lodash');
 import { of } from 'rxjs';
@@ -62,7 +63,7 @@ describe('OsdSmartListComponent', () => {
   configureTestBed({
     declarations: [OsdSmartListComponent],
     imports: [TabsModule, SharedModule, HttpClientTestingModule],
-    providers: [i18nProviders]
+    providers: [i18nProviders, TabsetComponent, TabsetConfig]
   });
 
   beforeEach(() => {
@@ -103,4 +104,26 @@ describe('OsdSmartListComponent', () => {
     expect(component.data).toEqual({});
     expect(component.incompatible).toBeTruthy();
   });
+
+  it('should display info panel for passed self test', () => {
+    initializeComponentWithData();
+    fixture.detectChanges();
+    const alertPanel = fixture.debugElement.query(By.css('cd-alert-panel'));
+    expect(component.incompatible).toBe(false);
+    expect(component.loading).toBe(false);
+    expect(alertPanel.attributes.size).toBe('slim');
+    expect(alertPanel.attributes.title).toBe('SMART overall-health self-assessment test result');
+    expect(alertPanel.attributes.type).toBe('info');
+  });
+
+  it('should display warning panel for failed self test', () => {
+    initializeComponentWithData(patchData('ata_smart_data.self_test.status.passed', false));
+    fixture.detectChanges();
+    const alertPanel = fixture.debugElement.query(By.css('cd-alert-panel'));
+    expect(component.incompatible).toBe(false);
+    expect(component.loading).toBe(false);
+    expect(alertPanel.attributes.size).toBe('slim');
+    expect(alertPanel.attributes.title).toBe('SMART overall-health self-assessment test result');
+    expect(alertPanel.attributes.type).toBe('warning');
+  });
 });
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.ts
index 26f0965ae98..24ae7a0436c 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-smart-list/osd-smart-list.component.ts
@@ -79,7 +79,10 @@ export class OsdSmartListComponent implements OnInit, OnChanges {
           // Build result
           result[deviceId] = {
             info: info,
-            smart: smartData.ata_smart_attributes,
+            smart: {
+              attributes: smartData.ata_smart_attributes,
+              data: smartData.ata_smart_data
+            },
             device: info.device.name,
             identifier: info.serial_number
           };
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.html b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.html
index a4c22848935..490164b22e1 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.html
@@ -1,20 +1,39 @@
 <alert type="{{ bootstrapClass }}">
   <table>
-    <tr>
-      <td rowspan="2" class="alert-panel-icon">
-        <i [ngClass]="[icons.large3x]" class="alert-{{ bootstrapClass }} {{ typeIcon }}"
-           aria-hidden="true"></i>
-      </td>
-      <td class="alert-panel-title">{{ title }}</td>
-    </tr>
-    <tr>
-      <td class="alert-panel-text">
-        <ng-content></ng-content>
-      </td>
-    </tr>
+    <ng-container *ngIf="size === 'normal'; else slim">
+      <tr>
+        <td *ngIf="showIcon"
+            rowspan="2" class="alert-panel-icon">
+          <i [ngClass]="[icons.large3x]" class="alert-{{ bootstrapClass }} {{ typeIcon }}"
+             aria-hidden="true"></i>
+        </td>
+        <td class="alert-panel-title">{{ title }}</td>
+      </tr>
+      <tr>
+        <td class="alert-panel-text">
+          <ng-container *ngTemplateOutlet="content"></ng-container>
+        </td>
+      </tr>
+    </ng-container>
+    <ng-template #slim>
+      <tr>
+        <td *ngIf="showIcon" class="alert-panel-icon">
+          <i class="alert-{{ bootstrapClass }} {{ typeIcon }}"
+             aria-hidden="true"></i>
+        </td>
+        <td class="alert-panel-title">{{ title }}</td>
+        <td class="alert-panel-text">
+          <ng-container *ngTemplateOutlet="content"></ng-container>
+        </td>
+      </tr>
+    </ng-template>
   </table>
 </alert>
 
+<ng-template #content>
+  <ng-content></ng-content>
+</ng-template>
+
 <div class="button-group text-right"
      *ngIf="backAction.observers.length > 0">
   <button class="btn btn-light tc_backButton"
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.scss b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.scss
index a663f9295dc..29ae0e2ff34 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.scss
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.scss
@@ -1,6 +1,6 @@
 .alert-panel-icon {
   vertical-align: top;
-  padding-right: 15px; // See @alert-padding in bootstrap/less/variables.less
+  padding-right: 0.5em;
 }
 
 .alert-panel-title {
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.ts
index 90ce8c361e0..12b2a832376 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/alert-panel/alert-panel.component.ts
@@ -14,11 +14,14 @@ export class AlertPanelComponent implements OnInit {
   bootstrapClass = '';
   @Output()
   backAction = new EventEmitter();
-
   @Input()
-  type: 'warning' | 'error' | 'info';
+  type: 'warning' | 'error' | 'info' | 'success';
   @Input()
   typeIcon: Icons | string;
+  @Input()
+  size: 'slim' | 'normal' = 'normal';
+  @Input()
+  showIcon = true;
 
   icons = Icons;