From: Neha Ojha <nojha@redhat.com>
Date: Wed, 13 Nov 2019 15:33:01 +0000 (-0800)
Subject: Revert "rocksdb: enable rocksdb_rmrange=true by default"
X-Git-Tag: v14.2.5~77^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=8758697a95f7319327b07c5336508affc6acf5dc;p=ceph.git

Revert "rocksdb: enable rocksdb_rmrange=true by default"

This reverts commit 29bafe57503066c962cc692a66178b083fd43343.

We have observed drastically poor performance when rocksdb_rmrange is
used for every key deletion.

This change is specific to nautilus, since we are experimenting with rocksdb_rmrange
along with https://github.com/ceph/ceph/pull/31442 in master.

Signed-off-by: Neha Ojha <nojha@redhat.com>
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 051dca4872f..1265a5d2051 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -3980,7 +3980,7 @@ std::vector<Option> get_global_options() {
     .set_description(""),
 
     Option("rocksdb_enable_rmrange", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
-    .set_default(true)
+    .set_default(false)
     .set_description("Refer to github.com/facebook/rocksdb/wiki/DeleteRange-Implementation"),
 
     Option("rocksdb_max_items_rmrange", Option::TYPE_UINT, Option::LEVEL_ADVANCED)