From: Jos Collin <jcollin@redhat.com>
Date: Fri, 31 Mar 2017 14:31:23 +0000 (+0530)
Subject: rbd: warning, ‘devno’ may be used uninitialized in this function
X-Git-Tag: v12.0.2~232^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=87c0fd23994d316ef41a776fb7d830e7935f60e9;p=ceph.git

rbd: warning, ‘devno’ may be used uninitialized in this function

The following warning appears during make. Fixed in both unmap_image() functions in krbd.cc

--
krbd.cc: In function ‘int krbd_unmap_by_spec(krbd_ctx*, const char*, const char*, const char*, const char*)’:
krbd.cc:608:65: warning: ‘devno’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   return do_unmap(ctx->udev, devno, build_unmap_buf(id, options));
                                                                 ^
krbd.cc:591:9: note: ‘devno’ was declared here
   dev_t devno;
--

Signed-off-by: Jos Collin <jcollin@redhat.com>
---

diff --git a/src/krbd.cc b/src/krbd.cc
index d1cdf5529779..fe0d8c2b2858 100644
--- a/src/krbd.cc
+++ b/src/krbd.cc
@@ -552,7 +552,7 @@ static int unmap_image(struct krbd_ctx *ctx, const char *devnode,
                        const char *options)
 {
   struct stat sb;
-  dev_t wholedevno;
+  dev_t wholedevno = 0;
   string id;
   int r;
 
@@ -588,7 +588,7 @@ static int unmap_image(struct krbd_ctx *ctx, const char *pool,
                        const char *image, const char *snap,
                        const char *options)
 {
-  dev_t devno;
+  dev_t devno = 0;
   string id;
   int r;