From: Michal Jarzabek <stiopa@gmail.com>
Date: Fri, 22 Apr 2016 17:51:55 +0000 (+0100)
Subject: rgw/rgw_op.cc: avoid copying in for loops
X-Git-Tag: v11.0.0~231^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=8839ccbf1512241ca74ad885740b83a5bb70095f;p=ceph.git

rgw/rgw_op.cc: avoid copying in for loops

Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
---

diff --git a/src/rgw/rgw_op.cc b/src/rgw/rgw_op.cc
index d0508213069b..fe50052ce35c 100644
--- a/src/rgw/rgw_op.cc
+++ b/src/rgw/rgw_op.cc
@@ -1824,7 +1824,7 @@ static void prepare_add_del_attrs(const map<string, bufferlist>& orig_attrs,
                                   map<string, bufferlist>& out_attrs,
                                   map<string, bufferlist>& out_rmattrs)
 {
-  for (const auto kv : orig_attrs) {
+  for (const auto& kv : orig_attrs) {
     const string& name = kv.first;
 
     /* Check if the attr is user-defined metadata item. */
@@ -1842,7 +1842,7 @@ static void prepare_add_del_attrs(const map<string, bufferlist>& orig_attrs,
                                   const set<string>& rmattr_names,
                                   map<string, bufferlist>& out_attrs)
 {
-  for (const auto kv : orig_attrs) {
+  for (const auto& kv : orig_attrs) {
     const string& name = kv.first;
 
     /* Check if the attr is user-defined metadata item. */
@@ -1867,7 +1867,7 @@ static void prepare_add_del_attrs(const map<string, bufferlist>& orig_attrs,
 static void populate_with_generic_attrs(const req_state * const s,
                                         map<string, bufferlist>& out_attrs)
 {
-  for (auto kv : s->generic_attrs) {
+  for (const auto& kv : s->generic_attrs) {
     bufferlist& attrbl = out_attrs[kv.first];
     const string& val = kv.second;
     attrbl.clear();