From: Yaniv Kaul Date: Thu, 19 Dec 2019 14:54:58 +0000 (+0200) Subject: lvm/activate.py: clarify error message: fsid refers to osd_fsid X-Git-Tag: v13.2.9~99^2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=88565b6bda8c2e0bcf3ebe4dd424b65d7f66b932;p=ceph.git lvm/activate.py: clarify error message: fsid refers to osd_fsid Users complained[1] the error message isn't clear, and they thought it referred to the cluster fsid instead of the osd_fsid. Made it clearer. [1] rook/rook#4547 Fixes: https://tracker.ceph.com/issues/43442 Signed-off-by: Yaniv Kaul (cherry picked from commit ff3ba9200a6b5856fbdf4372fe292a7b94dd2539) --- diff --git a/src/ceph-volume/ceph_volume/devices/lvm/activate.py b/src/ceph-volume/ceph_volume/devices/lvm/activate.py index d46db9edfa586..ebdb206246166 100644 --- a/src/ceph-volume/ceph_volume/devices/lvm/activate.py +++ b/src/ceph-volume/ceph_volume/devices/lvm/activate.py @@ -248,7 +248,7 @@ class Activate(object): elif osd_fsid and not osd_id: lvs.filter(lv_tags={'ceph.osd_fsid': osd_fsid}) if not lvs: - raise RuntimeError('could not find osd.%s with fsid %s' % (osd_id, osd_fsid)) + raise RuntimeError('could not find osd.%s with osd_fsid %s' % (osd_id, osd_fsid)) # This argument is only available when passed in directly or via # systemd, not when ``create`` is being used if getattr(args, 'auto_detect_objectstore', False):