From: Sage Weil <sage@redhat.com>
Date: Sun, 25 Dec 2016 18:23:06 +0000 (-0500)
Subject: mon/PGMap: remove CATEGORY column from 'df detail'
X-Git-Tag: v12.0.0~342^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=88d85ad7261a63266f2efae0c13cf35cd33d29d5;p=ceph.git

mon/PGMap: remove CATEGORY column from 'df detail'

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/qa/workunits/cephtool/test.sh b/qa/workunits/cephtool/test.sh
index 60fd51e30ee..6ff62df5865 100755
--- a/qa/workunits/cephtool/test.sh
+++ b/qa/workunits/cephtool/test.sh
@@ -626,7 +626,6 @@ function test_mon_misc()
   grep GLOBAL $TMPFILE
   grep -v DIRTY $TMPFILE
   ceph df detail > $TMPFILE
-  grep CATEGORY $TMPFILE
   grep DIRTY $TMPFILE
   ceph df --format json > $TMPFILE
   grep 'total_bytes' $TMPFILE
@@ -1884,8 +1883,8 @@ function test_mon_cephdf_commands()
     sleep 1
   done
 
-  cal_raw_used_size=`ceph df detail | grep cephdf_for_test | awk -F ' ' '{printf "%d\n", 2 * $4}'`
-  raw_used_size=`ceph df detail | grep cephdf_for_test | awk -F ' '  '{print $11}'`
+  cal_raw_used_size=`ceph df detail | grep cephdf_for_test | awk -F ' ' '{printf "%d\n", 2 * $3}'`
+  raw_used_size=`ceph df detail | grep cephdf_for_test | awk -F ' '  '{print $10}'`
 
   ceph osd pool delete cephdf_for_test cephdf_for_test --yes-i-really-really-mean-it
   rm ./cephdf_for_test
diff --git a/qa/workunits/rest/test.py b/qa/workunits/rest/test.py
index f12cf2be135..a6a52fc5874 100755
--- a/qa/workunits/rest/test.py
+++ b/qa/workunits/rest/test.py
@@ -130,9 +130,9 @@ if __name__ == '__main__':
     assert('epoch' in r.myjson['output'])
 
     assert('GLOBAL' in expect('df', 'GET', 200, 'plain').text)
-    assert('CATEGORY' in expect('df?detail=detail', 'GET', 200, 'plain').text)
+    assert('DIRTY' in expect('df?detail=detail', 'GET', 200, 'plain').text)
     # test param with no value (treated as param=param)
-    assert('CATEGORY' in expect('df?detail', 'GET', 200, 'plain').text)
+    assert('DIRTY' in expect('df?detail', 'GET', 200, 'plain').text)
 
     r = expect('df', 'GET', 200, 'json', JSONHDR)
     assert('total_used_bytes' in r.myjson['output']['stats'])
diff --git a/src/mon/PGMap.cc b/src/mon/PGMap.cc
index 72d39bcda26..adaddf5a8b1 100644
--- a/src/mon/PGMap.cc
+++ b/src/mon/PGMap.cc
@@ -1883,7 +1883,6 @@ void PGMap::dump_pool_stats(const OSDMap &osd_map, stringstream *ss,
     tbl.define_column("NAME", TextTable::LEFT, TextTable::LEFT);
     tbl.define_column("ID", TextTable::LEFT, TextTable::LEFT);
     if (verbose) {
-      tbl.define_column("CATEGORY", TextTable::LEFT, TextTable::LEFT);
       tbl.define_column("QUOTA OBJECTS", TextTable::LEFT, TextTable::LEFT);
       tbl.define_column("QUOTA BYTES", TextTable::LEFT, TextTable::LEFT);
     }
@@ -1957,8 +1956,6 @@ void PGMap::dump_pool_stats(const OSDMap &osd_map, stringstream *ss,
       tbl << pool_name
           << pool_id;
       if (verbose) {
-	tbl << "-";
-
         if (pool->quota_max_objects == 0)
           tbl << "N/A";
         else
diff --git a/src/test/mon/test_pool_quota.sh b/src/test/mon/test_pool_quota.sh
index e856e10885c..28c58bdc839 100755
--- a/src/test/mon/test_pool_quota.sh
+++ b/src/test/mon/test_pool_quota.sh
@@ -36,8 +36,8 @@ function TEST_pool_quota() {
    
     local poolname=testquoa
     ceph osd  pool create $poolname 20
-    local objects=`ceph df detail | grep -w $poolname|awk '{print $4}'`
-    local bytes=`ceph df detail | grep -w $poolname|awk '{print $5}'`
+    local objects=`ceph df detail | grep -w $poolname|awk '{print $3}'`
+    local bytes=`ceph df detail | grep -w $poolname|awk '{print $4}'`
 
     echo $objects
     echo $bytes
@@ -49,8 +49,8 @@ function TEST_pool_quota() {
     ceph osd pool set-quota  $poolname   max_objects 1000
     ceph osd pool set-quota  $poolname  max_bytes 1024
 
-    objects=`ceph df detail | grep -w $poolname|awk '{print $4}'`
-    bytes=`ceph df detail | grep -w $poolname|awk '{print $5}'`
+    objects=`ceph df detail | grep -w $poolname|awk '{print $3}'`
+    bytes=`ceph df detail | grep -w $poolname|awk '{print $4}'`
    
      if [ $objects != '1000' ] || [ $bytes != '1024' ] ;
        then