From: Casey Bodley <cbodley@redhat.com>
Date: Mon, 29 Jul 2019 15:51:16 +0000 (-0400)
Subject: rgw: user service removes old access keys in remove_old_indexes
X-Git-Tag: v15.1.0~1898^2^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=89a06ec757c6be956c5c151b4d643c9af99e4eac;p=ceph.git

rgw: user service removes old access keys in remove_old_indexes

Signed-off-by: Casey Bodley <cbodley@redhat.com>
---

diff --git a/src/rgw/services/svc_user_rados.cc b/src/rgw/services/svc_user_rados.cc
index 33636b396db..d7636d745b7 100644
--- a/src/rgw/services/svc_user_rados.cc
+++ b/src/rgw/services/svc_user_rados.cc
@@ -311,6 +311,16 @@ public:
       }
     }
 
+    for (const auto& [name, access_key] : old_info.access_keys) {
+      if (!new_info.access_keys.count(access_key.id)) {
+        ret = svc.user->remove_key_index(ctx, access_key, y);
+        if (ret < 0 && ret != -ENOENT) {
+          set_err_msg("ERROR: could not remove index for key " + access_key.id);
+          return ret;
+        }
+      }
+    }
+
     for (auto old_iter = old_info.swift_keys.begin(); old_iter != old_info.swift_keys.end(); ++old_iter) {
       const auto& swift_key = old_iter->second;
       auto new_iter = new_info.swift_keys.find(swift_key.id);