From: Sage Weil <sage@inktank.com>
Date: Wed, 27 Mar 2013 20:19:03 +0000 (-0700)
Subject: osd: disallow classes with flags==0
X-Git-Tag: v0.62~158^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=89c69016e1dddb9f3ca40fd699e4a995ef1e3eee;p=ceph.git

osd: disallow classes with flags==0

They must be RD, WR, or something....

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/src/osd/ClassHandler.cc b/src/osd/ClassHandler.cc
index f6a5acfbe81..6675e9e4fc4 100644
--- a/src/osd/ClassHandler.cc
+++ b/src/osd/ClassHandler.cc
@@ -142,6 +142,11 @@ ClassHandler::ClassMethod *ClassHandler::ClassData::register_method(const char *
 								    cls_method_call_t func)
 {
   /* no need for locking, called under the class_init mutex */
+  if (!flags) {
+    derr << "register_method " << name << "." << mname << " flags " << flags << " " << (void*)func
+	 << " FAILED -- flags must be non-zero" << dendl;
+    return NULL;
+  }
   dout(10) << "register_method " << name << "." << mname << " flags " << flags << " " << (void*)func << dendl;
   ClassMethod& method = methods_map[mname];
   method.func = func;