From: Islam AbdelRahman <tec@fb.com>
Date: Thu, 7 Jan 2016 17:48:29 +0000 (-0800)
Subject: Fix BlockBasedTableTest.NoopTransformSeek failure
X-Git-Tag: rocksdb-4.3~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=8a294d6673687dda848d0d34f55100d4ad2fba79;p=rocksdb.git

Fix BlockBasedTableTest.NoopTransformSeek failure

Summary:
table_test is failing because we are creating a temp InternalComparator

14:27:28 [ RUN      ] BlockBasedTableTest.NoopTransformSeek
14:27:28 pure virtual method called
14:27:28 terminate called without an active exception
14:27:28 /bin/sh: line 7: 2346261 Aborted                 (core dumped) ./$t

Test Plan: make table_test -j64 && ./table_test --gtest_filter="BlockBasedTableTest.NoopTransformSeek"

Reviewers: igor, sdong, anthony, rven

Reviewed By: rven

Subscribers: dhruba

Differential Revision: https://reviews.facebook.net/D52671
---

diff --git a/table/table_test.cc b/table/table_test.cc
index 8f1380e0..e1d1c09c 100644
--- a/table/table_test.cc
+++ b/table/table_test.cc
@@ -1260,8 +1260,9 @@ TEST_F(BlockBasedTableTest, NoopTransformSeek) {
   std::vector<std::string> keys;
   stl_wrappers::KVMap kvmap;
   const ImmutableCFOptions ioptions(options);
-  c.Finish(options, ioptions, table_options,
-           InternalKeyComparator(options.comparator), &keys, &kvmap);
+  const InternalKeyComparator internal_comparator(options.comparator);
+  c.Finish(options, ioptions, table_options, internal_comparator, &keys,
+           &kvmap);
 
   auto* reader = c.GetTableReader();
   for (int i = 0; i < 2; ++i) {