From: zjh <jhzeng93@foxmail.com>
Date: Fri, 26 Apr 2019 07:15:11 +0000 (+0800)
Subject: osd: Better error message when OSD count is less than osd_pool_default_size
X-Git-Tag: v12.2.13~93^2~7
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=8ab219477878730ebade1000db76e6322a3edbdc;p=ceph.git

osd: Better error message when OSD count is less than osd_pool_default_size

Fixes: http://tracker.ceph.com/issues/38617

Signed-off-by: zjh <jhzeng93@foxmail.com>
(cherry picked from commit 94237d36932b27961afffbe65d433af26c3fe513)

Conflicts:
	doc/rados/operations/health-checks.rst
- trivial
        src/mon/PGMap.cc
- cct->_conf->get_val in luminous
---

diff --git a/doc/rados/operations/health-checks.rst b/doc/rados/operations/health-checks.rst
index e261be19484..aa4ba460f73 100644
--- a/doc/rados/operations/health-checks.rst
+++ b/doc/rados/operations/health-checks.rst
@@ -408,6 +408,12 @@ Please refer to
 :doc:`placement-groups#Choosing-the-number-of-Placement-Groups` for
 more information.
 
+TOO_FEW_OSDS
+____________
+
+The number of OSDs in the cluster is below the configurable
+threshold of ``osd_pool_default_size``.
+
 SMALLER_PGP_NUM
 _______________
 
diff --git a/src/mon/PGMap.cc b/src/mon/PGMap.cc
index 31a3e975a54..1a005b24da5 100644
--- a/src/mon/PGMap.cc
+++ b/src/mon/PGMap.cc
@@ -3013,6 +3013,15 @@ void PGMap::get_health_checks(
     }
   }
 
+  // TOO_FEW_OSDS
+  auto osd_pool_default_size = cct->_conf->get_val<uint64_t>("osd_pool_default_size");
+  if (osdmap.get_num_osds() < osd_pool_default_size) {
+    ostringstream ss;
+    ss << "OSD count " << osdmap.get_num_osds()
+	 << " < osd_pool_default_size " << osd_pool_default_size;
+    checks->add("TOO_FEW_OSDS", HEALTH_WARN, ss.str());
+  }
+
   // SMALLER_PGP_NUM
   // MANY_OBJECTS_PER_PG
   if (!pg_stat.empty()) {