From: Loic Dachary Date: Tue, 13 Aug 2013 14:13:19 +0000 (+0200) Subject: ReplicatedPG: remove lookup_object_context method X-Git-Tag: v0.69~76^2~4 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=8c745944c9984414a3787c044ebd62c6efbd9e30;p=ceph.git ReplicatedPG: remove lookup_object_context method Both ReplicatedPG::lookup_object_context and ReplicatedPG::_lookup_object_context methods are provided by SharedPtrRegistry. http://tracker.ceph.com/issues/5510 refs #5510 Signed-off-by: Loic Dachary --- diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc index d8c14ec34d44..54d5d3a22650 100644 --- a/src/osd/ReplicatedPG.cc +++ b/src/osd/ReplicatedPG.cc @@ -4492,14 +4492,6 @@ void ReplicatedPG::handle_watch_timeout(WatchRef watch) eval_repop(repop); } -ObjectContext *ReplicatedPG::_lookup_object_context(const hobject_t& oid) -{ - map::iterator p = object_contexts.find(oid); - if (p != object_contexts.end()) - return p->second; - return NULL; -} - ObjectContextRef ReplicatedPG::create_object_context(const object_info_t& oi, SnapSetContext *ssc) { @@ -7468,7 +7460,7 @@ void ReplicatedPG::scan_range( handle.reset_tp_timeout(); ObjectContextRef obc; if (is_primary()) - obc = _lookup_object_context(*p); + obc = object_contexts.lookup(*p); if (obc) { bi->objects[*p] = obc->obs.oi.version; dout(20) << " " << *p << " " << obc->obs.oi.version << dendl; diff --git a/src/osd/ReplicatedPG.h b/src/osd/ReplicatedPG.h index 9d11ca2fe470..133be172a98e 100644 --- a/src/osd/ReplicatedPG.h +++ b/src/osd/ReplicatedPG.h @@ -298,15 +298,6 @@ public: void handle_watch_timeout(WatchRef watch); protected: - ObjectContext *lookup_object_context(const hobject_t& soid) { - if (object_contexts.count(soid)) { - ObjectContext *obc = object_contexts[soid]; - obc->ref++; - return obc; - } - return NULL; - } - ObjectContext *_lookup_object_context(const hobject_t& oid); ObjectContextRef create_object_context(const object_info_t& oi, SnapSetContext *ssc); ObjectContextRef get_object_context(const hobject_t& soid, bool can_create);