From: Igor Fedotov <ifedotov@suse.com>
Date: Wed, 1 May 2019 13:49:37 +0000 (+0300)
Subject: os/bluestore: dump onode if too many spanning blobs detected.
X-Git-Tag: v15.1.0~2647^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=8d103b15c9b27e157d9b3e4bec87f1d71c94d547;p=ceph.git

os/bluestore: dump onode if too many spanning blobs detected.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
---

diff --git a/src/common/legacy_config_opts.h b/src/common/legacy_config_opts.h
index d6bb8b2f36d2..74ab62d34ae1 100644
--- a/src/common/legacy_config_opts.h
+++ b/src/common/legacy_config_opts.h
@@ -1043,6 +1043,7 @@ OPTION(bluestore_default_buffered_write, OPT_BOOL)
 OPTION(bluestore_debug_misc, OPT_BOOL)
 OPTION(bluestore_debug_no_reuse_blocks, OPT_BOOL)
 OPTION(bluestore_debug_small_allocations, OPT_INT)
+OPTION(bluestore_debug_too_many_blobs_threshold, OPT_INT)
 OPTION(bluestore_debug_freelist, OPT_BOOL)
 OPTION(bluestore_debug_prefill, OPT_FLOAT)
 OPTION(bluestore_debug_prefragment_max, OPT_INT)
diff --git a/src/common/options.cc b/src/common/options.cc
index 7e7c7ae9a003..e5b6bc3e2d4b 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -4707,6 +4707,10 @@ std::vector<Option> get_global_options() {
     .set_default(0)
     .set_description(""),
 
+    Option("bluestore_debug_too_many_blobs_threshold", Option::TYPE_INT, Option::LEVEL_DEV)
+    .set_default(24*1024)
+    .set_description(""),
+
     Option("bluestore_debug_freelist", Option::TYPE_BOOL, Option::LEVEL_DEV)
     .set_default(false)
     .set_description(""),
diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc
index b623eeb4cc88..962d1db5780b 100644
--- a/src/os/bluestore/BlueStore.cc
+++ b/src/os/bluestore/BlueStore.cc
@@ -2541,6 +2541,9 @@ void BlueStore::ExtentMap::reshard(
       shard_end = sp->offset;
     }
     Extent dummy(needs_reshard_begin);
+    bool was_too_many_dump = false;
+    auto too_many_blobs_threshold =
+      g_conf()->bluestore_debug_too_many_blobs_threshold;
     for (auto e = extent_map.lower_bound(dummy); e != extent_map.end(); ++e) {
       if (e->logical_offset >= needs_reshard_end) {
 	break;
@@ -2597,6 +2600,16 @@ void BlueStore::ExtentMap::reshard(
             b->id = bid;
 	    spanning_blob_map[b->id] = b;
 	    dout(20) << __func__ << "    adding spanning " << *b << dendl;
+	    if (!was_too_many_dump &&
+	      too_many_blobs_threshold &&
+	      spanning_blob_map.size() >= size_t(too_many_blobs_threshold)) {
+		dout(0) << __func__
+		        << " spanning blob count exceeds threshold, "
+			<< spanning_blob_map.size() << " spanning blobs"
+			<< dendl;
+		_dump_onode<0>(cct, *onode);
+	      was_too_many_dump = true;
+	    }
 	  }
 	}
       } else {