From: David Zafman <david.zafman@inktank.com>
Date: Tue, 12 Mar 2013 23:47:36 +0000 (-0700)
Subject: Simplify may_write()
X-Git-Tag: v0.60~77
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=8d8f892c8d2bb3c07f5159f7951ac9d607970873;p=ceph.git

Simplify may_write()

CEPH_MDS_OP_CREATE has CEPH_MDS_OP_WRITE bit set so already checked

Signed-off-by: David Zafman <david.zafman@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>
---

diff --git a/src/messages/MClientRequest.h b/src/messages/MClientRequest.h
index 9dc938363299..7190ab277269 100644
--- a/src/messages/MClientRequest.h
+++ b/src/messages/MClientRequest.h
@@ -99,8 +99,7 @@ public:
   bool may_write() {
     return
       (head.op & CEPH_MDS_OP_WRITE) || 
-      (head.op == CEPH_MDS_OP_OPEN && (head.args.open.flags & (O_CREAT|O_TRUNC))) ||
-      (head.op == CEPH_MDS_OP_CREATE);
+      (head.op == CEPH_MDS_OP_OPEN && (head.args.open.flags & (O_CREAT|O_TRUNC)));
   }
 
   int get_flags() const {