From: Radoslaw Zarzynski Date: Wed, 3 Apr 2024 14:37:20 +0000 (+0000) Subject: crimson/osd: fix std::moving in ShardServices X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=8dc8c907d514cd539f13d541cbfe73dbd66eaa26;p=ceph-ci.git crimson/osd: fix std::moving in ShardServices ``` /home/rzarzynski/ceph2/src/crimson/osd/shard_services.cc:595:9: required from here /home/rzarzynski/ceph2/src/crimson/osd/shard_services.cc:596:10: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] 596 | auto [pool, name, ec_profile] = std::move(std::get<0>(ret).get0()); | ^~~~~~~~~~~~~~~~~~~~~~~~ /home/rzarzynski/ceph2/src/crimson/osd/shard_services.cc:596:10: note: remove ‘std::move’ call /home/rzarzynski/ceph2/src/crimson/osd/shard_services.cc:597:10: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] 597 | auto coll = std::move(std::get<1>(ret).get0()); | ^~~~ /home/rzarzynski/ceph2/src/crimson/osd/shard_services.cc:597:10: note: remove ‘std::move’ call ``` Signed-off-by: Radoslaw Zarzynski --- diff --git a/src/crimson/osd/shard_services.cc b/src/crimson/osd/shard_services.cc index 09da0412416..9f54d657ae8 100644 --- a/src/crimson/osd/shard_services.cc +++ b/src/crimson/osd/shard_services.cc @@ -595,8 +595,8 @@ seastar::future> ShardServices::make_pg( std::move(get_pool_info_for_pg), std::move(get_collection) ).then([pgid, create_map, this](auto &&ret) { - auto [pool, name, ec_profile] = std::move(std::get<0>(ret).get()); - auto coll = std::move(std::get<1>(ret).get()); + auto [pool, name, ec_profile] = std::get<0>(std::move(ret)).get(); + auto coll = std::get<1>(std::move(ret)).get(); return seastar::make_ready_future>( new PG{ pgid,