From: Radosław Zarzyński <rzarzyns@redhat.com>
Date: Mon, 23 May 2022 16:57:23 +0000 (+0200)
Subject: common/bl: drop buffer::raw_char.
X-Git-Tag: v18.0.0~450^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=8fcdd31ad1b75687772db0237332b4bec32128c9;p=ceph.git

common/bl: drop buffer::raw_char.

Its sole users were the implementations of `clone_empty()`
of `buffer::raw` we removed one commit ago.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
---

diff --git a/src/common/buffer.cc b/src/common/buffer.cc
index e32503c2890..b363b99573f 100644
--- a/src/common/buffer.cc
+++ b/src/common/buffer.cc
@@ -201,26 +201,6 @@ static ceph::spinlock debug_lock;
   /*
    * primitive buffer types
    */
-  class buffer::raw_char : public buffer::raw {
-  public:
-    MEMPOOL_CLASS_HELPERS();
-
-    explicit raw_char(unsigned l) : raw(l) {
-      if (len)
-	data = new char[len];
-      else
-	data = 0;
-      bdout << "raw_char " << this << " alloc " << (void *)data << " " << l << bendl;
-    }
-    raw_char(unsigned l, char *b) : raw(b, l) {
-      bdout << "raw_char " << this << " alloc " << (void *)data << " " << l << bendl;
-    }
-    ~raw_char() override {
-      delete[] data;
-      bdout << "raw_char " << this << " free " << (void *)data << bendl;
-    }
-  };
-
   class buffer::raw_claimed_char : public buffer::raw {
   public:
     MEMPOOL_CLASS_HELPERS();
@@ -2270,7 +2250,6 @@ MEMPOOL_DEFINE_OBJECT_FACTORY(buffer::raw_malloc, buffer_raw_malloc,
 			      buffer_meta);
 MEMPOOL_DEFINE_OBJECT_FACTORY(buffer::raw_posix_aligned,
 			      buffer_raw_posix_aligned, buffer_meta);
-MEMPOOL_DEFINE_OBJECT_FACTORY(buffer::raw_char, buffer_raw_char, buffer_meta);
 MEMPOOL_DEFINE_OBJECT_FACTORY(buffer::raw_claimed_char, buffer_raw_claimed_char,
 			      buffer_meta);
 MEMPOOL_DEFINE_OBJECT_FACTORY(buffer::raw_static, buffer_raw_static,
diff --git a/src/include/buffer.h b/src/include/buffer.h
index bb75a3d88be..dfb97facbc6 100644
--- a/src/include/buffer.h
+++ b/src/include/buffer.h
@@ -127,7 +127,6 @@ struct error_code;
   class raw_static;
   class raw_posix_aligned;
   class raw_hack_aligned;
-  class raw_char;
   class raw_claimed_char;
   class raw_unshareable; // diagnostic, unshareable char buffer
   class raw_combined;